Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Allow to convert 3/5/7/9/11/13/15 bpp JP2 files to TIF #729

Closed
wants to merge 2 commits into from
Closed

[fix] Allow to convert 3/5/7/9/11/13/15 bpp JP2 files to TIF #729

wants to merge 2 commits into from

Conversation

julienmalik
Copy link
Collaborator

This issue comes from the decompression of Sentinel-2 Earth Observation satellite products, which are currently delivered as 15-bpp JP2 files.

OpenJPEG 2.0.1 and 2.1 are affected by a serious bug when using opj_decompress to convert the JP2 files to TIF format : the actual pixels values are twice the expected values.

Current trunk simply refuses to convert the data to TIF and errors out with the message :

imagetotif: Bits=0, Only 1, 2, 4, 6, 8, 10, 12, 14 and 16 bits implemented

This commit simply considers the unsupported 3/5/7/9/11/13/15 bit-precision as if they were 4/6/8/10/12/14/16 bpp data, to at least allow TIF conversion. The bug affecting 2.0.1 and 2.1 cannot be reproduced then, and pixel values in TIF are as expected.

Please note that Kakadu does output a 15 bpp TIF :

$ tiffinfo S2A_OPER_MSI_L1C_TL_SGS__20151127T035842_A002245_T52SEG_B08_KDU.tif
TIFF Directory at offset 0x8 (8)
  Image Width: 10980 Image Length: 10980
  Resolution: 0.01, 0.01 (unitless)
  Bits/Sample: 15
  Sample Format: unsigned integer
  Compression Scheme: None
  Photometric Interpretation: min-is-black
  Samples/Pixel: 1
  Rows/Strip: 814
  Planar Configuration: single image plane

while with this fix, OpenJPEG outputs a 16bpp TIF :

tiffinfo S2A_OPER_MSI_L1C_TL_SGS__20151127T035842_A002245_T52SEG_B08_OPJ_TRUNK.tif
TIFF Directory at offset 0xe5f3628 (241120808)
  Image Width: 10980 Image Length: 10980
  Bits/Sample: 16
  Compression Scheme: None
  Photometric Interpretation: min-is-black
  Orientation: row 0 top, col 0 lhs
  Samples/Pixel: 1
  Rows/Strip: 1
  Planar Configuration: single image plane

I do have some issues with the 15bpp TIFF files in other software (namely the Java JAI TIF reader), so for my use case it is better to keep only 1, 2, 4, 6, 8, 10, 12, 14 and 16 bits TIF.

@boxerab
Copy link
Contributor

boxerab commented Mar 25, 2016

Cool : I saw this problem with sentinel images. 15 bpp was failing.

@boxerab
Copy link
Contributor

boxerab commented Mar 26, 2016

It might be wise to add an odd bit depth JP2 image to the test suite.

@detonin
Copy link
Contributor

detonin commented Apr 12, 2016

@julienmalik I agree with Aaron. Could you provide such odd bit depth JP2 image so that we can add it to the test suite and reproduce the bug before fixing it ? Best way to do so is to create a PR in openjpeg-data with the new file and then add the test in https://github.com/uclouvain/openjpeg/blob/master/tests/nonregression/test_suite.ctest.in
thanks

@julienmalik
Copy link
Collaborator Author

Agreed

@julienmalik
Copy link
Collaborator Author

After further testing, seems like 12bpp TIFF is not supported by all implementation, so it could help to have a command line option to force the bitdepth of the output. I'll try to come up with something.

mayeut added a commit to mayeut/openjpeg that referenced this pull request Apr 22, 2016
@mayeut
Allow to write 3/5/7/9/11/13/15 bpp TIF files
29e8a1c 
Update uclouvain#729
@mayeut mayeut mentioned this pull request Apr 22, 2016
Closed
@mayeut
Copy link
Collaborator

mayeut commented Apr 23, 2016 •
edited
Loading

@julienmalik, the command line option to force output bit depth already exists.

-p <comp 0 precision>[C|S][,<comp 1 precision>[C|S][,...]]
    OPTIONAL
    Force the precision (bit depth) of components.
    There shall be at least 1 value. Theres no limit on the number of values (comma separated, last values ignored if too much values).
    If there are less values than components, the last value is used for remaining components.
    If 'C' is specified (default), values are clipped.
    If 'S' is specified, values are scaled.
    A 0 value can be specified (meaning original bit depth).

mayeut added a commit to mayeut/openjpeg-data that referenced this pull request Apr 23, 2016
@mayeut
Add 3/5/7/9/11/13/15 bpp TIF files
f53578c 
Update uclouvain/openjpeg#729
mayeut added a commit to mayeut/openjpeg that referenced this pull request Apr 23, 2016
@mayeut
Allow to write 3/5/7/9/11/13/15 bpp TIF files
74e8143 
Update uclouvain#729
@mayeut mayeut mentioned this pull request Apr 23, 2016
Merged
mayeut added a commit to uclouvain/openjpeg-data that referenced this pull request Apr 23, 2016
@mayeut
Add 3/5/7/9/11/13/15 bpp TIF files (#18)
97d0cd7 
Update uclouvain/openjpeg#729
@mayeut mayeut mentioned this pull request Apr 23, 2016
Merged
@mayeut mayeut closed this Apr 23, 2016
@julienmalik
Copy link
Collaborator Author

many thanks @mayeut ! much more than actually expected !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienmalik @boxerab @detonin @mayeut